[Scummvm-devel] ATTN. Porters. Changed list of files to include

[Max Horn]

Am 12.06.2007 um 09:11 schrieb Lars Persson:

> Hi!
> I have now tested on a M600 and these are my findings:
> a) No crash (thats the main point I think)
> b) Loading the 7K line pred.dic takes around 1,5 minutes.
> c) Loading the 3K (Sierra) pred.dic takes around 30 seconds.
>
> So I guess its really room for improvement, but at least it does  
> n't crash
> on target.

I know it's a bit too late now, and it helps nobody, but still, I  
gotta repeat what Eugene sayid: It really, really, *reaaly* would  
help if everybody made such tests at the beginning of the testing  
period, not at the end. *sigh*. Avoding such nasty situations is  
*precisely* why we make a branch and let some time pass, to give  
porters and engine authors alike a chance to test features. And of  
course in this specific case the feature was around for a long time  
now, too ... :-/

Anyway, that's not very constructive, so let's get on with it and try  
to solve it :-).

Did you make any tests (profiling) what is taking so long? You hinted  
that the line-by-line reading might be slow. Why, is it unbuffered?  
Maybe it would help to read the whole file at once into a  
MemoryStream, then read that libe-by-line? The attached patch does  
that, it also contains some timing information. Loading&parsing the  
current 8k lines / 124k bytes pred.dic takes about 150ms here. So  
that makes the symbian device about 600 times slower. Very odd :-(

Bye,
Max

-------------- next part --------------
A non-text attachment was scrubbed...
Name: agi-pred.patch
Type: application/octet-stream
Size: 1269 bytes
Desc: not available
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20070612/d2d7b68c/attachment.obj>