[Scummvm-devel] Memory/speed loss in scumm engine

[Max Horn]

Am Mi, 2.04.2008, 00:40, schrieb Neil Millstone:
>
>
> I did some messing around to try and find the problem a few weeks ago.
> I binary chopped the dates, and I found that the binary size grows
> massively somewhere between the 9th and 13th January.   I'm going to do
> some more chopping to try and track down the change which caused it, but
> it's not anything immediately obvious.
>
> 17th March 2008  20:24  2460736
> 17th February 2008 20:24  2461760
> 17th January 2008 20:24 2434624
> 13th January 2008 20:24 2434624
> 9th January 2008 20:24 1591872
> 1st January 2008 20:24 1590848
> 17th December 2007 20:24 1556032
>
> Again, if this rings a bell for anyone, please let me know, because
> it'll save me a lot of time!

It doesn't ring a bell, however, can you tell us the precise revisions you
checked out on Jan 9/13? Makes it easier to get a precise diff and review
all the changes. I did glance over a (long) diff between those dates, but
nothing struck me as being a good candidate for this.

But then I didn't review *everything* in detail, that would take far too
long when one does not know what to watch out for precisely. So I think it
would still be the most effective to just continue the binary search.
There are about 100-120 revs in that date range, so with just 4 more
iterations it should be narrowed down to less than 10 "candidate" revs,
with 7 iterations down to the precise rev. With "svn co -r REV" this
should be easy enough (although of course having to wait for the
compilation *is* very annoying, yet still easier than combing the source
with a tooth brush ;).


Cheers,
Max