[Scummvm-devel] Getting rid of auto dirty rects (Gob, Kyra, Saga
Max Horn
max at quendi.de
Thu Dec 4 14:41:15 CET 2008
Am 04.12.2008 um 13:43 schrieb Johannes Schickel:
> Max Horn schrieb:
>> Hi folks,
>>
>> I would really like to get rid o the bugged dirty rect code in the
>> SDL (and GP2x) backend. To get an idea of why this is bugged, read
>> <https://sourceforge.net/tracker2/?func=detail&aid=1538880&group_id=37116&atid=418820
>> >.
>>
>> Grepping for kFeatureAutoComputeDirtyRects shows that only Gob,
>> Kyra and SAGA seem to be using this anyway:
>>
> Actually KYRA only disables that flag :-). As you can see in the
> code below:
>
>> ./engines/kyra/screen.cpp: _system-
>> >setFeatureState(OSystem::kFeatureAutoComputeDirtyRects, false);
> So for KYRA it wouldn't make any difference at all I guess.
Perfect, thanks. Didn't notice that at all :). Note that
kFeatureAutoComputeDirtyRects is disabled by default (though... hmm...
do we ever reset feature flags when we RTL and then start another
engine? hmmm).
Cheers,
Max
More information about the Scummvm-devel
mailing list