[Scummvm-devel] Streaming sounds in Scumm games

[Max Horn]

Am 06.08.2009 um 00:13 schrieb Neil Millstone:

>
> Max Horn wrote:
>>
>> Am 05.08.2009 um 20:55 schrieb Johannes Schickel:
>>
>>> Hi again,
>>>
>>> I did take a short look into the VOC code. It seams the transition
>>> should be pretty straight forwarded. One could adapt the  
>>> "makeVOCStream"
>>> factory to match the ones for MP3, OGG/Vorbis and FLAC along with it
>>> too. (That's an old TODO from our TODO page), this would then ease  
>>> to
>>> make it clear, that the code will take over the "stream" object.
>>
>> Yup, something like that was always the long-term plan for the  
>> various
>> sound decoder "streams": Provide a factory which takes a
>> (Seekable)ReadStream (whether it's a file or a memory stream would be
>> irrelevant), and turn it into an AudioStream. :)
>>
>> Just never got around to implement this everywhere properly :/.
>>
> I've just got one working that pretty much works for the VOCs in Sam &
> Max.  When it's finished, someone needs to take a look over it though.

Please submit it via the patch tracker then, I'll try to review it  
ASAP then (as my scarce time permits, at least). I am sure others will  
be interested, too.

>
> Is it too late to put this in for the next release?  I could put the
> streaming on an #ifdef so it only runs on the DS port.

As Johannes said, it's not too late, esp. if it is #ifdef'ed for the  
DS port. Although I would strongly consider enabling it on desktop  
ports, too, for heavy testing. If this turns out to be a problem in  
1.0.0rc1, we can still disable it for the final release. Or enable it  
for more platforms.  :)



Cheers,
Max