[Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[43496] scummvm/branches/branch-1-0-0/backends/platform /ds/arm9/source

[Johannes Schickel]

neil at millstone.demon.co.uk wrote:
> If you wanted to look into it, feel free, but I must get a beta of the DS port out today so it has enough testing time before tagging.
>
> I'm not entirely sure if it's a bug in the Scumm engine or somewhere my code. On the other hand, I couldn't locate anywhere that stops the CD audio in Scumm games when we return to launcher. I would need to look into it a little further before blaming the main codebase, hence my fix.
>   

Seems like SCUMM (and other engines) didn't call AudioCD.stop(), when 
they quit, thus when there's playback via the OSystem CD interface, it 
would never be stopped, till another engine using CD audio does it. For 
ripped files it would stop though, since the Engine destructor stops all 
sound handles and thus also the one of the AudioCDManager used for 
ripped audio files playback.
SCUMM and AGOS did destroy the AudioCDManager on quit, but that did not 
call the OSystem::stopCD function, so that did not prevent the CD 
playback from continuing either.

I did fix that in trunk now and will backport it to branch too.

// Johannes