[Scummvm-devel] OSystem::clearScreen documentation / implementation

[Paul Gilbert]

On Sun, Feb 15, 2009 at 1:45 PM, Johannes Schickel <lordhoto at gmail.com>wrote:

> Eugene Sandulenko schrieb:
> > My 2 cents is to extend this method a bit and add optional parameter to
> > it, that is the color value, defaulting to 0. And of course, reflect
> > that in the documentation.
> >
>
> Yeah I thought of that too, but I guess we should then rename it to
> something like OSystem::fillScreen.
>

I was thinking along the same lines too.. there just seems something hackish
about having it as an extra parameter, since it becomes just as efective for
filling the screen with any given palette index rather than just clearing
the screen.

If we did implement a separate fillScreen method, we could have the existing
clearScreen method simply call fillScreen(0). That way engines that
specifically need use a non-standard palette index can call fillScreen
rather than clearScreen, but we keep the clearScreen() as is for the
existing engines.

Paul.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20090215/ec94cc95/attachment.html>