[Scummvm-devel] SCI: line drawing functions

[Lars Skovlund]

On Mon, Feb 23, 2009 at 08:21:39AM -0500, Max Horn wrote:

> I would be careful with replacing. If you are sure the two methods
> produce pixel identical output, it could be considered. But if not,
> better don't do it right now, or wait until Walter or Lars confirmed
> it is OK. As in AGI, stuff might depend on specific pixels being set
> or not, for priority screens. Well, or not, but an expert should clear
> this.

Max's intuition is correct. The line-drawing functions are used for
drawing on the control map (which is separate from the priority map,
unlike in AGI). An incorrect implementation can make certain scenes
difficult or impossible to beat. Others (the majority) will appear
fine, making a direct replacement very difficult. This is perhaps more
true of the code in sci_pic_0.cpp than gfx_line.cpp, but still...

Lars
(Oh, and Filippos: Please don't forward mails to me personally; I'll
read and respond to them when I have the time)