[Scummvm-devel] SCI & Tinsel for 0.14.0?

[Max Horn]

Am 02.07.2009 um 13:42 schrieb Sven Hesse:

> On 2009-07-02 13:01:22 +0200, Max Horn wrote:
>> Hi there,
>>
>> yes, Tinsel should be made official and enabled.
>
> Apropos: I take it by your post in the forums that you're okay with
> the compressed sample files patch (#2815426)?
> (<https://sourceforge.net/tracker/?func=detail&atid=418822&aid=2815426&group_id=37116 
> >)

That's not what my forum post said. My post said that it was OK to  
submit the patch, and that in principle I don't object to the patch.  
But I haven't had a chance to look at the patch yet, so I certainly  
cannot say whether I approve or disapprove.

>
> It seems to work well (after fixing a mistake m_kiewitz made with  
> MKID_BE ;)).
> A quick size comparison:
>                   Uncompressed   Vorbis compressed
> DW1 english.smp :      329MB            106MB
> DW2 english1.smp:      225MB             97MB
> DW2 english2.smp:      101MB             44MB
>
> So, can I commit it, or are there any objections?

If you reviewed the patch and vouch for its quality, I see no issue  
with that. Adding a new compression tool now means that Remere should  
be notified of it, though, to give him a chance to merge that, too ;).

Bye,
Max