[Scummvm-devel] Fw: SCI: SQ4 Talkie DoSound

[M. Kiewitz]

>> That's enough for the scripts? Well then it's fine. I'm not really familiar with the SCI engine, I noticed that doing SI_FINISHED (also) let the script continue.

>Having played the first scene in SQ4 again, it loses sync when the sound effect is heard, so the current implementation is definitely not right. Perhaps the scripts are waiting for the sound sample to finish and we're telling them that it already has finished (by returning the full sound duration), so it seems that we shouldn't return the full sound duration to the scripts like what kDoAudio does, but rather do it with an iterator. So your initial assumption is right, my apologies, we do need an iterator for this to work correctly (as SCI syncs some animations with sound and music, which clearly fails in that scene in SQ4CD), but I'm not sure if we need a new iterator (most likely), or if the current iterator can be expanded to handle sound effects as well.

>If you're willing to work on this, feel free to do it :) A good test case would be the first scene in SQ4CD, the scrolling animation after the ship flies away.

Okay, will do it.
It seems that the script really needs an "DoSound event" back. Will create an iterator that will take milliseconds as input and then create SI_FINISHED after that duration. So it could get reused if another such case pops up.

Regards
  M. Kiewitz