[Scummvm-devel] Mac OS X Problems in gsoc2009-16bit Branch
Johannes Schickel
lordhoto at scummvm.org
Mon Jul 13 21:35:14 CEST 2009
Max Horn wrote:
> Indeed, that needs to be done in any case. In addition, we should add
> a "PixelFormat::validate()" method which performs some extra checks to
> ensure that a given PixelFormat makes sense -- e.g. verify that the
> various components do not overlap (which is easy to do -- just compute
> the bitmasks for each, and then AND them pairwise, if the result is
> not 0 you overlap).
>
That makes me wonder, our current way to determine the overlay format,
uses the same method. So far it worked fine, that may be because SDL
always makes the Aloss 8 there, since the Amask we pass is zero. I guess
we might think of adding some paranoia check for that too.
// Johannes
More information about the Scummvm-devel
mailing list