[Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[42899] scummvm/branches/gsoc2009-draci/engines/draci

[Denis Kasak]

On Wed, Jul 29, 2009 at 21:50, Robert Špalek<rspalek at gmail.com> wrote:
> On Wed, Jul 29, 2009 at 12:38 PM, <dkasak13 at users.sourceforge.net> wrote:
>>
>> Revision: 42899
>>          http://scummvm.svn.sourceforge.net/scummvm/?rev=42899&view=rev
>> Author:   dkasak13
>> Date:     2009-07-29 19:38:02 +0000 (Wed, 29 Jul 2009)
>>
>> Log Message:
>> -----------
>> * Made Game::loop() exit conditionally depending on whether the internal
>> Game::_shouldExitLoop variable is set.
>> * Added mechanisms for signalling whether the main game loop should exit
>> or not (Game::setExitLoop() and Game::shouldExitLoop())
>
> I don't understand the difference between _shouldExitLoop and _shouldQuit.
>  they both are tested in the loop and the loop is exited if one of them is
> true, just at a different point.  is that intentional or do you plan to
> finish the transition to a new system in a later commit?

_shouldExitLoop is used for determining whether the main game loop has
finished its job and can return to the caller, kind of like the
original player does it (it does a repeat..until on a variable that
tells it when to quit). _shouldQuit is when we actually want to quit
the game.

Currently the loop is very buggy as the scripts depend on a very
particular architecture of the loop so when I've implemented most of
it, I'll probably be able to use the loop status and substatus to do
without _shouldQuit.

-- 
Denis Kasak