[Scummvm-devel] FINAL DECISION: Bitdepth/pixel format API concerns

[Eugene Sandulenko]

On Sat, 13 Jun 2009 19:44:54 +0200
Rafał Rzepecki <divided.mind at gmail.com> wrote:
> My vote is (although I'm not sure if I have any right to vote, so
> let's make it "my voice") to KISS it.
Rafal, thank you for nicely summarizing whole discussion.


Now, after reading today's e-mail, I see that all key persons voted
their opinion, and here is the solution which is:

  a) Simple
  b) Straigtforward
  c) Takes in majority of opinions in this thread.

Here:
> Let the engine request however
> exotic colorspace it wants (as long as it's supported by our
> conversion routines, ie. the PixelFormat struct) and let the backend
> worry about how to draw it. Unless the engine just wants whatever
> high/truecolor mode (as when doing conversion anyway), then let it ask
> for any mode and let it find out what mode it was provided.
Jody, please, do it this way.

> All this talk is probably more text already than all the code would
> have been, while it isn't clear (at least to me) than any such clever
> optimizations (at risk of leaking abstraction, no less), which would
> certainly need such discussions, are at all neccessary.
Well, this feature waited so long to be implemented because we knew
that solution is not that straightforward. Thus, this discussion is
really needed.

But now as I see we have good approach.

If there will ever be need of anything changed, then it will be
completely different task of refactoring and rewriting. So far I see
that this approach will satisfy needs of all engines which exist and
those which are in progress.


Eugene