[Scummvm-devel] Static code analysis with cppcheck

[Ori Avtalion]

Hi,

I ran the cppcheck tool on the ScummVM codebase and got the following 
errors.

If you consider some of these errors useful to fix, perhaps it's a good 
idea to run the tool periodically.

Engines:

[engines/agi/preagi_mickey.cpp:224]: (error) Memory leak: buffer
[engines/agi/preagi_mickey.cpp:247]: (error) Memory leak: buffer
[engines/agi/preagi_mickey.cpp:734]: (error) Memory leak: buffer
[engines/agi/preagi_mickey.cpp:756]: (error) Memory leak: buffer
[engines/agi/preagi_winnie.cpp:1065]: (error) Memory leak: buffer
[engines/agos/string.cpp:317]: (error) Overlapping data buffer filename
[engines/agos/subroutine.cpp:358]: (error) Overlapping data buffer
     filename
[engines/kyra/sound_towns.cpp:44]: (error) Class Towns_EuphonyChannel
     which is inherited by class Towns_EuphonyFmChannel does not have
     a virtual destructor
[engines/kyra/sound_towns.cpp:44]: (error) Class Towns_EuphonyChannel
     which is inherited by class Towns_EuphonyPcmChannel does not have a
     virtual destructor
[engines/lure/res_struct.cpp:1429]: (error) Mismatching allocation and
     deallocation: paramList
[engines/m4/resource.cpp:155]: (error) Overlapping data buffer destName
[engines/sci/sfx/softseq/amiga.cpp:591]: (error) Memory leak: buffers

Backends:

[backends/platform/dc/selector.cpp:454]: (error) Mismatching allocation
     and deallocation: games
[backends/platform/gp2x/gp2x.cpp:162]: (error) Resource leak: newfp
[backends/platform/gp2xwiz/gp2xwiz-main.cpp:128]: (error) Resource
     leak: newfp
[backends/platform/iphone/osys_main.cpp:296]: (error) Resource leak:
     newfp
[backends/platform/sdl/main.cpp:80]: (error) Resource leak: newfp
[backends/platform/wii/osystem.cpp:214]: (error) Mismatching allocation
     and deallocation: mutex
[sound/softsynth/adlib.cpp:73]: (error) Class AdlibPart which is
     inherited by class AdlibPercussionChannel does not have a virtual
     destructor

Sound:

[sound/softsynth/adlib.cpp:73]: (error) Class AdlibPart which is
     inherited by class AdlibPercussionChannel does not have a virtual
     destructor