[Scummvm-devel] Finding the theme archive via SearchMan

Angus Lees alees at google.com
Wed Apr 28 15:42:50 CEST 2010


Android packages are basically zip files.  In the Android port, I
bundle kyra.dat, scummmodern.zip, etc into the package zip to avoid
the user having to install anything extra -- and then I have a
Common::Archive sub-class that I hook in via
addSysArchivesToSearchSet.  It actually works really well ...

... except for themes.  ThemeEngine.cpp currently does its own
directory searching, etc using FSNode and doesn't use SearchMan or the
standard ArchiveMember methods.  In the Android port, I patched
ThemeEngine.cpp to do the latter but in the process lost the ability
to use unzipped themes since the Archive member methods don't present
a sub-directory equivalent.

So:  is preserving the ability to use unzipped themes important to anyone?

I can (presumably) make the code do a combination of the two
approaches if required - the downside will be some code duplication,
since the two approaches are a few functions of almost-but-not-quite
the same code.

Thoughts?

 - Gus




More information about the Scummvm-devel mailing list