[Scummvm-devel] Testing needed for GSoC OpenGL Branch

vgvgf vgvgvgf at gmail.com
Fri Aug 6 05:29:53 CEST 2010


Hi Hubert,

If commenting those lines does not break the AmigaOS4 port, then an
option can be to add a "#ifndef __amigaos4__" for not defining those
key codes when compiling for AmigaOS4. If it is enabled
ENABLE_KEYMAPPER when compiling, there will be some problems with the
< and > keys though, as the value used in the SDK differs from the one
in common/keyboard.h.
The other option can be to use some #undef KEYCODE_LESS and #undef
KEYCODE_GREATER, but I do not know if that could lead to some
problems.

But, by now, I will add "#ifndef __amigaos4__" as a quick solution,
and hope it can be fixed later.

Regards
Alejandro

On Thu, Aug 5, 2010 at 3:44 PM, Hubert Maier <raziel_nosgoth at web.de> wrote:
> Hallo vgvgvgf,
>
>> I get an error on the very same file
>
>>     C++      backends/graphics/opengl/opengl-graphics.o
>> In file included from ./backends/graphics/graphics.h:31,
>>                  from ./backends/graphics/opengl/opengl-graphics.h:30,
>>                  from backends/graphics/opengl/opengl-graphics.cpp:28:
>> ./common/keyboard.h:69: error: expected identifier before numeric constant
>> ./common/keyboard.h:69: error: expected `}' before numeric constant
>> ./common/keyboard.h:69: error: expected unqualified-id before numeric
>> constant ./common/keyboard.h:183: error: extra ';'
>> ./common/keyboard.h:236: error: 'KeyCode' does not name a type
>> ./common/keyboard.h:259: error: expected `)' before 'kc'
>> ./common/keyboard.h:265: error: expected `)' before 'kc'
>> ./common/keyboard.h: In member function 'void KeyState::reset()':
>> ./common/keyboard.h:272: error: 'keycode' was not declared in this scope
>> ./common/keyboard.h:272: error: 'KEYCODE_INVALID' was not declared in this
>> scope ./common/keyboard.h: In member function 'bool
>> KeyState::operator==(const KeyState&) const':
>> ./common/keyboard.h:289: error: 'keycode' was not declared in this scope
>> ./common/keyboard.h:289: error: 'const struct KeyState' has no member named
>> 'keycode'
>> ./common/keyboard.h: At global scope:
>> ./common/keyboard.h:293: error: expected declaration before '}' token
>> gmake: *** [backends/graphics/opengl/opengl-graphics.o] Error 1
>
> Replying to self as i have fixed this error on the Residual port aswell
>
> There are defines of
> KEYCODE_LESS = 60,
> and
> KEYCODE_GREATER = 62,
> which are both already defined in SDK:include/include_h/intuition/ intuition.h on
> AmigaOS4
>
> A workaround for me is to comment out those two lines in common/keyboard.h, lines
> 69 and 71, but of course this will break other ports.
>
> Ciao,
>
> Hubert
> --
>    Amiga On(e)ce, now and (OS)4 ever ...
> <sb>
> AOneXE - MPC7447/7457/950
> A4000D - MC68060/50
> <sb>
> In crises that force people to choose among alternative courses of action, most
> people will choose the worst one possible.
> -- Rudin's Law
> <sb>
> AMIGA!    The path visionaries will follow ... always!
>
>




More information about the Scummvm-devel mailing list