[Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[52120] scummvm/trunk/common/fs.cpp (and r52121)

[Max Horn]

Am 17.08.2010 um 13:22 schrieb Johannes Schickel:

> On Tue, Aug 17, 2010 at 9:56 AM, Max Horn <max at quendi.de> wrote:
>> Beyond that, I also think our handling of file clashes is not quite right, as detailed in my previous email.
>> 
> 
> Hi,
> 
> maybe that mail you talk about did not arrive here yet, but actually I
> don't see any mail of you, which talks about file clashes.

I was referring to my mail sent 0:44 MESZ, were I discussed what happens if multiple files with the same name are contained in an Archive, and how FSDir and ZipArchive behave differently for that, and how it becomes even worse when mixing those with ZipArchive.

A quick "fix" for the inconsistency Eugene observed would be to switch FSDir to use GenericArchiveMember instead of FSNode for its members. However, this will not resolve the general issue with Archive: An archive *can* have multiple members with identical names (just use a flat FSDir, or aggregate multiple archives with like named files via a SearchSet). We either need to extend our code further to prevent that. Or (and I think I prefer that) we should embrace this as a chance, and allow multiple members with identical names, by adopting a behavior as I described in my email from 0:23 MESZ.


Bye,
Max