[Scummvm-devel] Testing needed for GSoC OpenGL Branch

[Andre Heider]

Just tried your branch. Here's what I noticed:

- the window is only resizable in AR mode "None". No big deal, but
maybe the ctrl+alt+a option is too "hidden" for the enduser and that
mode could be changed automatically when resizing?
- other apps like media players have 2 resizing modes 1) free resizing
2) resizing while keeping the AR, one beeing implemented with a
modifier key. Maybe that's a more user-friendly solution?
- when compiling with --enable-vkeybd it segfaults on startup. see
backtrace below. works fine without.
- already mentioned, but still: the global "AR correction" option is
ignored. All 3 opengl AR modes work on a 320x200 source, where is
should (?) autostretch games using that resolution to 320x240

not related to your work, out of scope for this branch, but other
shortcomings worth mentioning:
- the fonts are ugly in in AR mode "None" and filter mode "Nearest"
when enlarging the window. Maybe we should add higher res fonts when
the opengl feature is compiled in? Or maybe even use freetype for
desktops builds?
- the hardcoded mouse cursor theme scaling backfires on enlarging the
window. It autoscales the cursor to factor 2, and limits the scale to
factor 3 (IIRC). When using free scaling, it only uses integer
scaling, giving a huge cursor e.g. when scaling by 1.5

Overall: nice work, this is a very welcome addition for desktop ports!

Regards,
Andre

Backtrace for --enabled-vkeybd:
#0  0x0000000000501cae in ModularBackend::getScreenChangeID (this=0x7c7010)
    at /home/andre/devel/scummvm/gsoc2010-opengl/backends/modular-backend.cpp:115
No locals.
#1  0x0000000000524ae3 in VirtualKeyboardGUI (this=0x852170, kbd=0x84c7b0)
    at /home/andre/devel/scummvm/gsoc2010-opengl/backends/vkeybd/virtual-keyboard-gui.cpp:86
No locals.
#2  0x00000000005201f1 in VirtualKeyboard (this=0x84c7b0)
    at /home/andre/devel/scummvm/gsoc2010-opengl/backends/vkeybd/virtual-keyboard.cpp:46
No locals.
#3  0x00000000005038ed in DefaultEventManager (this=0x842620, boss=0x7c7018)
    at /home/andre/devel/scummvm/gsoc2010-opengl/backends/events/default/default-events.cpp:56
No locals.
#4  0x00000000005050e4 in SdlEventManager (this=0x842620, boss=0x7c7018)
    at /home/andre/devel/scummvm/gsoc2010-opengl/backends/events/sdl/sdl-events.cpp:56
No locals.
#5  0x0000000000493e7c in OSystem_SDL::initBackend (this=0x7c7010)
    at /home/andre/devel/scummvm/gsoc2010-opengl/backends/platform/sdl/sdl.cpp:87
        __PRETTY_FUNCTION__ = "virtual void OSystem_SDL::initBackend()"
#6  0x00000000004937f3 in OSystem_POSIX::initBackend (this=0x7c7010)
    at /home/andre/devel/scummvm/gsoc2010-opengl/backends/platform/sdl/posix/posix.cpp:51
No locals.
#7  0x0000000000496b28 in scummvm_main (argc=1, argv=0x7fffffffe568)