[Scummvm-devel] ENGINES: Pausing the engine while debugger console visible

[Max Horn]

Hi there!

as there was no opposition at all to this proposal, I am going to implement it shortly. Since in fact Johannes was the only dev to reply, and he immediately implemented this change in Kyra, I'll be even bolder and ignore my originally proposed careful approach; I figure if I wait for all engine authors to test and enable this, it'll never happen.

Therefore, I will change the default implementation of GUI::Debugger::preEnter and ::postEnter to (un)pause the active engine. I will also remove empty pre/postEnter implementations, and tweak existing non-trivial implementation as appropriate (at least when it seems relatively safe to me).

It is quite possibly that this will cause regressions. So everybody is asked to test the debug consoles of as many engines as possible and look out for regressions and other oddities. 
In case of regressions, a quick and dirty fix is to simply override pre/postEnter with empty methods. Of course much better is to figure out what went wrong, and fix it properly. I'll be happy to discuss such issues with any engine developer as needed.


Cheers,
Max


Am 01.11.2010 um 13:22 schrieb Max Horn:

> Hi there,
> 
> the following concerns all Engine maintainers whose engine implements a debugger console, via GUI::Debugger. Feedback by all engine authors solicited. Engine authors can also immediately proceed to implement this if they desire so. 
> 
> If there is no big outcry over this, and no serious objections, then I expect this to be implemented gradually over time by me and other people.
> 
> 
> Proposed change:
> ===============
> The engine should be paused when entering the debugger console, and unpaused afterwards. Specifically by using Engine::pauseEngine.

[...]