[Scummvm-devel] Broken Sword 1 for Mac, regression

[Thierry Crozat]

Hi,

I wrote the patch that caused this regression and when I tested it,  
it obviously didn't crash for me. To make sure I just tried ScummVM  
1.0.0 with my Macintosh BS1 and I don't get the crash either.  
Everything seems to be fine with that version.

Looking at the code to refresh my memory, this is normal: for the  
full version where the speech files are named speech1.clu (or clv/clf/ 
cl3) and speech2.clu, calling initCowSystem() with currentCD set to  
zero was already a no-op since it couldn't find any file to open  
(unless you happen to have a file named speech0.clu). There are two  
exceptions: the demo whose speech file is named cows.mad and  
supposedly (I have not tried) playing from the CD which opens  
speech.clu. The name of these files do not depend on the value of  
currentCD and therefore this could indeed lead to _cowFile being  
opened while currendCD was zero. I think these are the only two cases  
where it could happen (unless it could happen with the PSX version as  
well).

Your changes fix this anyway and I cannot see any reason why they  
could be bad (but just to make sure I have also tested my full  
version with those changes and it still works).

Thierry

Le 8 janv. 10 à 20:09, Torbjörn Andersson a écrit :

> Hi,
>
> Recently, a regression was found in the Macintosh version of Broken
> Sword 1 which affected the demo, and quite possibly the full  
> version as
> well:
>
> http://sourceforge.net/tracker/index.php? 
> func=detail&aid=2928411&group_id=37116&atid=418820
>
> I believe I have fixed this (see r47171), but it would be good if
> someone who has the full version could test it too, both in 1.0 (to  
> see
> if it crashes) and the trunk (to see if it works).
>
> If the patch works as intended, it's probably a good candidate for the
> 1.0 branch.
>
> Torbjörn Andersson
>
> ---------------------------------------------------------------------- 
> --------
> This SF.Net email is sponsored by the Verizon Developer Community
> Take advantage of Verizon's best-in-class app development support
> A streamlined, 14 day to market process makes app distribution fast  
> and easy
> Join now and get one step closer to millions of Verizon customers
> http://p.sf.net/sfu/verizon-dev2dev
> _______________________________________________
> Scummvm-devel mailing list
> Scummvm-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/scummvm-devel