[Scummvm-devel] VideoPlayer improvement: video positioning.

[Filippos Karapetis]

> Vladimir Menshakov <whoozle at yandex.ru> wrote:
> 
> > VideoPlayer renders video in the center of the screen which makes
> > post-processing more complicated as it should be :) I see two
> > possible solutions: 1) Remove postProcess(byte *) and replace it with
> > virtual method "render" or something. VideoPlayer's default
> > implementation will do copyFrameToBuffer(centerx, centery). 2) Allow
> > manual _frameX/Y modification via other method/extended arguments.
> Sounds like a sound idea to me.


The second solution sounds better, imho. E.g. there could be a new method,
"setFrameLocation(x, y)" which would change the default placement.

The VideoPlayer class was created to simplify video playing. Videos SHOULD
be centered by default, as in most cases, games just play a video centered
at full screen. Different placements are certainly possible if you roll out your
own video implementation, so if you need more functionality than the one 
provided by the default video player, it would be better to create your own
implementation to suit your needs, unless it's a change which doesn't
complicate the default video player a lot - it's there to simplify things, after
all :)

Do tell, why do you need to play a full screen video at a different screen
position? (out of curiosity)

Regards
Filippos
 		 	   		  
_________________________________________________________________
Hotmail: Powerful Free email with security by Microsoft.
http://clk.atdmt.com/GBL/go/196390710/direct/01/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20100111/ad5a55cb/attachment.html>