[Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[50664] scummvm/trunk

[Max Horn]

Am 05.07.2010 um 02:09 schrieb anguslees at users.sourceforge.net:

> Revision: 50664
>          http://scummvm.svn.sourceforge.net/scummvm/?rev=50664&view=rev
> Author:   anguslees
> Date:     2010-07-05 00:09:41 +0000 (Mon, 05 Jul 2010)
> 
> Log Message:
> -----------
> Skip /dev/sequencer MIDI on Android.
> 

Seeing how many backends have to override this, I guess it would be better if we changed this so that it is only enabled if explicitly enabled (e.g. by configure, when it notices a UNIX system with /dev/sequencer support). Say, by introducing a #define ENABLE_SEQ_MIDI or so.

Bye,
Max


> Modified Paths:
> --------------
>    scummvm/trunk/backends/midi/seq.cpp
>    scummvm/trunk/base/plugins.cpp
> 
> Modified: scummvm/trunk/backends/midi/seq.cpp
> ===================================================================
> --- scummvm/trunk/backends/midi/seq.cpp	2010-07-05 00:04:18 UTC (rev 50663)
> +++ scummvm/trunk/backends/midi/seq.cpp	2010-07-05 00:09:41 UTC (rev 50664)
> @@ -28,7 +28,7 @@
>  *    both the QuickTime support and (vkeybd http://www.alsa-project.org/~iwai/alsa.html)
>  */
> 
> -#if defined(UNIX) && !defined(__BEOS__) && !defined(__MAEMO__) && !defined(__MINT__)
> +#if defined(UNIX) && !defined(__BEOS__) && !defined(__MAEMO__) && !defined(__MINT__) && !defined(__ANDROID__)
> 
> #include "common/util.h"
> #include "sound/musicplugin.h"
> 
> Modified: scummvm/trunk/base/plugins.cpp
> ===================================================================
> --- scummvm/trunk/base/plugins.cpp	2010-07-05 00:04:18 UTC (rev 50663)
> +++ scummvm/trunk/base/plugins.cpp	2010-07-05 00:09:41 UTC (rev 50664)
> @@ -175,7 +175,7 @@
> 		#if defined(UNIX) && defined(USE_ALSA)
> 		LINK_PLUGIN(ALSA)
> 		#endif
> -		#if defined(UNIX) && !defined(__BEOS__) && !defined(__MAEMO__) && !defined(__MINT__)
> +		#if defined(UNIX) && !defined(__BEOS__) && !defined(__MAEMO__) && !defined(__MINT__) && !defined(__ANDROID__)
> 		LINK_PLUGIN(SEQ)
> 		#endif
> 		#if defined(__MINT__)
> 
> 
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
> 
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Sprint
> What will you do first with EVO, the first 4G phone?
> Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
> _______________________________________________
> Scummvm-cvs-logs mailing list
> Scummvm-cvs-logs at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/scummvm-cvs-logs
>