[Scummvm-devel] ENGINES: Pausing the engine while debugger console visible

[Max Horn]

Am 01.11.2010 um 23:19 schrieb Johannes Schickel:

> On 11/01/2010 01:22 PM, Max Horn wrote:
>> --------------
>> I propose a gradual introduction of this change. For each engine using a debugger, we modify (resp. add) the Debugger::preEnter() / postEnter() implementations, adding calls to Engine::pauseEngine(true/false) into them. And possibly removing any existing functionality (e.g. for pausing music).
>> This way, we can perform the change step by step, for each engine independently; if regressions are detected, we can easily focus on fixing up the affected engine specifically, up to the ability to easily revert the change for that engine only.
>> 
>> On the long run, I think we should insert the pauseEngine calls into GUI::Debugger itself. Three approaches come to mind:
>> 1) Insert pauseEngine(true) before preEnter is called, and pauseEngine(true) after postEnter is called.
>> 2) Insert pauseEngine(true) after preEnter is called, and pauseEngine(true) before postEnter is called.
>> 3) Insert pauseEngine(true) into the default preEnter() implementation, similarly for postEnter().
> 
> Hi,
> 
> I take that is pauseEngine(false) in/before/after postEnter though, right?

Ooops! Yes of course. :)

> 
> Anyway I just implemented that in Kyra, it should work all right (or at 
> least not worse than before ;-).

Excellent :).


Bye,
Max