[Scummvm-devel] SCI script error detection

[Johannes Schickel]

On Wed, Oct 6, 2010 at 11:50 PM, Willem Jan Palenstijn <wjp at usecode.org> wrote:
> Hi,
>
> We currently detect the use uninitialized variables by SCI scripts
> automatically at run-time ("sci_valgrind"), and error out when we find any.
> The proper workaround/initialization is then added for each specific case
> manually.
>
> I think we should maybe change this to warnings for the release version, to
> prevent ones that were missed during testing from seemingly "crashing" ScummVM.
> (We could defaulting to init-to-zero behaviour maybe.)
>

Hi,

I am not exactly one of the SCI developers, but I think changing it to
a warning for the release makes sense. I had one uninitialized read
myself when I played KQ6 (and that was after we already had two
reports about KQ6CD being completable IIRC, without that one found)
and it was quite annoying that ScummVM just quit, but for a
development build it seemed fine. The biggest disadvantage I see with
changing it into a warning is that we do not have any way to show
warnings to the user when he has the console disabled. So I guess it
would be neat to still bring up the debugger with the warning message
and a polite "request" to report about it on our tracker.

// Johannes