[Scummvm-devel] SCI script error detection

[Max Horn]

Am 07.10.2010 um 08:19 schrieb Eugene Sandulenko:

> On Wed, 6 Oct 2010 21:50:34 +0000
> Willem Jan Palenstijn <wjp at usecode.org> wrote:
>> I think we should maybe change this to warnings for the release
>> version, to prevent ones that were missed during testing from
>> seemingly "crashing" ScummVM. (We could defaulting to init-to-zero
>> behaviour maybe.)
> If you really want those to be eventually fixed, I wouldn't do that.
> Getting people to test games these days becomes more and more harder,
> and mass-"testing" of the release build will help you to discover every
> bug in SCI games.

I am actually not sure whether letting ScummVM crash a lot is a good way to attract testers on the long run, or, for that matter, any users ;).

But as a compromise, we could do what M.Kiewitz suggested: Just show the warning in a dialog resp. in the console, and ask the user to provide feedback, pretty please, with sugar atop. Warn the user that continuing may cause issues (including an unrecoverable broken gamestate), but *do* allow the user continue (defaulting to a "zero" value as in the past). I think we'll still get feedback from any interested parties (these forced interruptions will still be quite annoying, after all), but those people who are not that much interested in providing feedback won't be too much bothered.

We can just make that change on the release branch; and later merged it back into trunk. We could make this new code conditional on RELEASE_BUILD, as was suggested, but personally I'd just always enable it to work like that.


Cheers,
Max