[Scummvm-devel] Broken Sword 2.5 engine

[Eugene Sandulenko]

On Wed, 13 Oct 2010 04:23:43 +0200
Sven Hesse <drmccoy at users.sourceforge.net> wrote:

> Hej hej!
> 
> A few more things:
> 
> 1.
> On my system at least, the code that's currently in the trunk fails to
> compile with an error:
> | ./engines/sword25/kernel/bs_stdint.h:50: error: conflicting
> declaration ‘typedef long long int int64_t’
> | /usr/include/sys/types.h:198: error: ‘int64_t’ has a previous
> declaration as ‘typedef long int int64_t’
Actualy these days there is a single place where it is used, and that
place is 3 lines of code. That typedef could be removed completely and
that spot in gfx/framecounter.cpp refactored.

And yes, I finished commit, as the last one with removing directories
was manual one.

> 2.
> | engines/sword25/kernel/outputpersistenceblock.cpp:111: error: call
> of overloaded ‘write(size_t&)’ is ambiguous Casting the size_t to an
> int fixes it, but I wasn't sure whether sev was actually finished
> commiting or if git-svn just stopped (he's not answering ATM, so I
> guess he went to sleep) 
Yes, our code so far was compiled and run only on 32-bit machines.
Potentially there also could be endianness issues.

> 3.
> There's some more memory corruption going on normal play:
I've fixed number of those, but there is a lot of work to do.

> 4.
> Just starting the game, going through the intro and then quitting
> makes valgrind show at least 7.7MB in leaked memory.
Oh yeah.

Another thing to mention is that as you may see, initial code naming
conventions vastly differ from our own. Currently only part of the code
was converted by following rules:

  - For class variables turn m_ prefix into _ and add _ where it was
    omitted
  - Lowercase first letter in all class methods
  - Lowercase first letter in all variable names

Those are main things left in this area. And of course, consult the
TODO.


Eugene


-- 
Eugene Sandulenko
ScummVM Team co-leader
http://www.scummvm.org