[Scummvm-devel] Broken Sword 2.5 engine

[Eugene Sandulenko]

On 13 October 2010 14:07, Max Horn <max at quendi.de> wrote:
> Some remarks:
>
> 1) Communication on this engine was not too good, at least as I remember experiencing it -- but maybe I missed something? As I recall it, a discussion on whether to merge it was started in August, some concerns were voiced, but never addressed. Then the discussion died away, silence. Then suddenly it hits trunk.
> In retrospect, it seems the "should we merge this?" discussion was not very serious :/. And I am quite unhappy that we now have a full copy of LUA sitting in our repository, despite explicit concerns about it.
Actually my questions went unanswered. See my mail from August 1st in
the "Broken Sword 2.5" thread and from September 19th "Broken Sword
2.5 engine is ready to be merged" where I raise specifically those
questions. Unfortunately they went unanswered.

Again, Lua could potetnially be put outside of the tree, it is not a
problem, though we have to lock to that specific version because of
Pluto, persistency library.

> 2) This engine is currently not being tested by buildbot, as neither libpng nor libtheora are installed for most of the cross compilers. I hope that it will be easy to install them at least for the Debian port; in any case, it would be great if "somebody" (resp. each maintainer) could take care of installing these libs, at least for ports where it might make sense.
And that is known issue.

> 4) The following warnings are generated on my system (note that I use -Werror, which is why those show up as errors). I hope the Sword 2.5 engine devs will address them shortly:
That is also known issue. I wanted to have wider zoo of
compilers/wider developer audience, specifically for reports like the
one below.

Global constructors and destructors plagued this engine, I know.
Eventually those will go away.


Eugene