[Scummvm-devel] Broken Sword 2.5 engine

[Eugene Sandulenko]

On Tue, 19 Oct 2010 16:58:20 +0200
yotam barnoy <yotambarnoy at gmail.com> wrote:

> Additionally, lua references clock() and rename() instead of
> corresponding functionality in our base code. It also calls socket
> functions, which should be completely removed. All of these currently
> require linking the PSP plugins with extra, mostly unneeded libraries.
We have 2 options on the plate:
  - Remove Lua from our tree completely and rely on it as an external
    library. But I think that in this case we're going back to the same
    problem, i.e. PSP cannot call libraries out of plugins
  - Remove that functionality from our Lua. Neither is used by Sword25.

> > Rather than conditionally adding -lpng to the plugin link flags, I
> > think it would be nicer if the PNG loading went through the common
> > graphics code, like for example the JPEG code in graphics/.
> >
> > In addition to this, it'd be nice if the PNG writing code from
> > Sword25::Screenshot::SaveToFile() would use the existing thumbnail
> > code instead.
> >
> >
> > Can someone from this engine please comment on the feasibility of
> > the above?   Thanks.
I see no problem with moving that PNG loader to our common code. As of
thumbnails, Paul could reply on that.

Also I don't really like current screenshot handling code since it has
a whole screen copy into temporary bugger on every frame. I.e. we're
shuffling around almost 2MB of data on every frame (800*600*4). That
should've been slowing down things tremendously.


Eugene