[Scummvm-devel] Patch submission workflow

[Max Horn]

Am 05.04.2011 um 12:50 schrieb Johannes Schickel:

> On 04/05/2011 10:54 AM, Max Horn wrote:
>> 
>> So, yes, submitting "patches" directly via a github pull request is fine. And for complex stuff, it is actually preferable. However, not everybody is comfortable with git, and therefore we definitely still want to let people use the regular patch tracker.
> 
> About patch tracker submissions, do we want to have patches created by 
> git format-patch nowadays? That would allow us to keep the original 
> author name + email in theory.

Well, my view is that we prefer github pull requests over patch submission; and for patch submissions, we prefer "git format-patch" style over "plain" patches. But we should still accept plain patches, else we cut off potentially useful contributions.

Cheers,
Max