[Scummvm-devel] KYRA - Eye of the Beholder extension

[A. Milburn]

On Fri, Dec 02, 2011 at 01:54:04PM +0100, Johannes Schickel wrote:
> In fact I have no fears about that and I didn't really talk about it.
> I merely said we add code really specific to an RPG, which is built up
> on a common framework with Kyra1-3 and not on a common engine. If
> that's fine with everybody then it's good, if people don't like that
> then it's bad. And this is *not* a point about code maintainability,
> but *what* kind of engine code we accept, i.e. non-trivial code not
> targeting adventures.

Well - 'common framework' is quite different from some shared file formats.
The LoL/EoB code seems to be built on top of shared Kyra code for sound, for
graphics, for internal timers, even for the input? As discussed on IRC, the
existing code (including LoL) is not well-seperated so it's difficult for an
outsider to tell exactly where the line is within the engine.

> This is directly related to my point that EoB code addition is
> non-trivial code (which might even be considered a whole engine) only
> to target RPGs. If in the case of subengines, we do not really care
> about that much, then it's fine.

Well, in a situation where it is almost entirely just game logic needed for
a new subengine, no-one seems (any more) to be that concerned about it.

> So once again: If we think the reason that EoB 1+2 shares framework
> code with Kyra games is enough to accept it as "subengine", then it's
> fine to add it. That's for me the sole remaining question to be
> answered, but it seems people try to avoid to answer that. So please

I don't think anyone can answer that in an informed manner without having a
much clearer idea of what 'framework code' is, and I imagine everyone's line
between 'engine' and 'framework' is going to differ anyway...

As I already said, I have no problem with the merge, and I see merging
subengine work into mainline as the best solution, if they are sharing more
than just file formats, which seems clearly the case for EoB.

- fuzzie