[Scummvm-devel] AUDIO: Forbid adding timestamps with differing framerate

[Tarek Soliman]

On Sun, Feb 13, 2011 at 10:04:44AM -0600, Tarek Soliman wrote:
> The recent change by max that forbids adding timestamps with differing
> framerates broke the monkey island 1 fanpatch that adds speech.
> (I think it's called ultimate talkie edition)
> 
> It fails on the newly added assert.
> 
> I've temporarily worked around it by reverting 633b8ed27784
> 
> Where do I start with debugging this? I think it is caused by the
> game scripts being modified.

I found that it is related to the flac cd audio.
Disabling that (by not including the audio tracks extras directory) fixes
it for now. I will try again with ogg when it's done reencoding.

attached is the backtrace
-- 
Tarek
-------------- next part --------------
#0  0xb7fe2424 in __kernel_vsyscall ()
#1  0xb7a00751 in raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
#2  0xb7a03b82 in abort () at abort.c:92
#3  0xb79f98b8 in __assert_fail (assertion=0x8b96d3b "_framerate == ts._framerate", file=0x8b96d20 "audio/timestamp.cpp", line=151, 
    function=0x8b96d60 "void Audio::Timestamp::addIntern(const Audio::Timestamp&)") at assert.c:81
#4  0x088cf222 in Audio::Timestamp::addIntern (this=0xbfffdcc0, ts=...) at audio/timestamp.cpp:151
#5  0x088cf31b in Audio::Timestamp::operator- (this=0xbfffdd08, ts=...) at audio/timestamp.cpp:174
#6  0x088c6b64 in Audio::SubSeekableAudioStream::SubSeekableAudioStream (this=0x8f275a8, parent=0x8f3a540, start=..., end=..., disposeAfterUse=DisposeAfterUse::YES)
    at audio/audiostream.cpp:232
#7  0x088c6373 in Audio::makeLoopingAudioStream (stream=0x8f3a540, start=..., end=..., loops=1) at audio/audiostream.cpp:160
#8  0x088574f7 in DefaultAudioCDManager::play (this=0x8dce668, track=22, numLoops=1, startFrame=10575, duration=0, only_emulate=false)
    at backends/audiocd/default/default-audiocd.cpp:75
#9  0x080831b3 in Scumm::Sound::playCDTrack (this=0x8eaac78, track=22, numLoops=1, startFrame=10575, duration=0) at engines/scumm/sound.cpp:1031
#10 0x08080ff9 in Scumm::Sound::playSound (this=0x8eaac78, soundID=99) at engines/scumm/sound.cpp:337
#11 0x08080688 in Scumm::Sound::processSoundQueues (this=0x8eaac78) at engines/scumm/sound.cpp:138
#12 0x0808061a in Scumm::Sound::processSound (this=0x8eaac78) at engines/scumm/sound.cpp:125
#13 0x0807e238 in Scumm::ScummEngine::scummLoop_handleSound (this=0x8e863c0) at engines/scumm/scumm.cpp:2389
#14 0x0807d5dd in Scumm::ScummEngine::scummLoop (this=0x8e863c0, delta=6) at engines/scumm/scumm.cpp:2171
#15 0x0807cb9c in Scumm::ScummEngine::go (this=0x8e863c0) at engines/scumm/scumm.cpp:1971
#16 0x0807ef44 in Scumm::ScummEngine::run (this=0x8e863c0) at ./engines/scumm/scumm.h:485
#17 0x0804f341 in runGame (plugin=0x8ca2378, system=..., edebuglevels=...) at base/main.cpp:213
#18 0x0804fed1 in scummvm_main (argc=1, argv=0xbfffee54) at base/main.cpp:423
#19 0x0804e3f3 in main (argc=1, argv=0xbfffee54) at backends/platform/sdl/posix/posix-main.cpp:48