[Scummvm-devel] Some useless includes in various engines

[Max Horn]

Hi Arnaud,

Am 02.01.2011 um 12:42 schrieb Arnaud Boutonné:

> Hi everybody,
> 
> While looking at the way midi is handled in engines, I discovered some useless includes.
> Could you take a look at those, if you're working on one of those engines?

My recommendation: Just remove them yourself, as long as you can verify that things still compile. I recommend doing this only in a build with as many features enabled as possible (so using --enable-all-engines among other things).

This is how I have done it on countless occasions in the past ;). There is a small risk that you accidentally break some special build variant, but if so, it's easy to catch, and easy to fix the regression -- namely, re-add the #include, but this time with a comment that explains when it is needed. Resp. guarded with some #ifdefs matching the special build variant it is needed for.

But for the headers you list, I think it's quite unlikely that there'll be regressions, as long as the regular build compiles.


Cheers,
Max