[Scummvm-devel] ScummVM 1.3.1 was "retagged"

[Thierry Crozat]

Le 7 juil. 2011 à 19:48, Eugene Sandulenko a écrit :

> On 7 July 2011 20:24, Andre Heider <a.heider at gmail.com> wrote:
>> builds from that version segfault when the theme path is set to a
>> directory containing e.g. the translation file from master.
>> Applying 38c99889 fixes that.
>> I'm not sure if that justifies a retag, I tend to say "yes" since we
>> have just one global config file.
> No, no retag because of this. Fresh install or upgrade will not be
> affected by this. The developers know what they are doing.

Also while in master it is looking in the theme path first for the translations.dat file, in the 1.3 branch it is still using SearchMan before the theme path. So the problem is platform dependent. For example on a mac the translation file is in the application bundle and the SearchMan finds it here. So even if there is a translations.dat file from master in the theme path this is not an issue (I just made the test). My understanding is that on Windows the file is embedded in the executable and looked there first as well. There remains a potential issue on other platforms but beside Linux I am not sure you will have many platforms where the user will want both a 1.3.1 and 1.4.git ScummVM on the same computer/device. So hopefully the number of users impacted will be small.

Thierry