[Scummvm-devel] ATTN Engine authors

[Max Horn]

Am 10.06.2011 um 23:35 schrieb Max Horn:

> Hi there,
> 
> to all engine authors (esp. if you work on out-of-tree engines): I just committed a major revision of how the Advanced Detector is inited. I switched all in-tree engines away from using ADParams. In fact, ADParam will soon go away, so you should adapt your engines to use that ASAP.
> 
> To explain: I added a new AdvancedMetaEngine constructor which doesn't take an ADParam anymore; instead it takes the only three values of the former ADParam that *every* engine must supply. Any other ADParam values that the (meta) engine may want to set to a value differing from the default (say, the number of bytes checked for MD5 computations) can then be overridden in the engines' custom (Advanced)MetaEngine subclass. Just look at the in-tree engines (esp. their "detection.cpp" files) to see how it done know; you may also want to take a look at the diffs of my recent commits. It should be fairly obvious for now, as an ADParam still exists inside AdvancedMetaEngine.
> 
> That ADParam will also go, though; ADParam will be merged into AdvancedMetaEngine. Adapting to that then will be a trivial thing, so, you'll just have to search & replace "params." by "_" (to change e.g. "params.descs" to "_descs"). But this has not yet happened, and I'll let you know when it does happen.

*bing* so this happened now: ADParams is no more. It has been merged into AdvancedMetaEngine. Moreover, various details of AdvancedMetaEngine have been changed, like how file based fallback has to be implemented. Please look at the corresponding commits to see how to adapt your external engines. If something is unclear, don't hesitate to ping me.

Cheers,
Max