[Scummvm-devel] Splitting common/util.h -> engines/util.h, maybe splitting common

[Thierry Crozat]

On 20 June 2011 00:06, Max Horn <max at quendi.de> wrote:
> Alas, most likely, things will just stay as they are; as I am apparently the only one who seems to be unhappy with the current state of affairs.

No you are not the only one. I find both the common and engines
directories to be a bit of a mess and that doesn't help to get into a
code I am not familiar with.

>
>> Don't know if that's what you meant. engines/ itself seems
>> already a bit cluttered to me, with helper tools like the advancedDetector
>> and the new obselete.cpp mixed in with the 'shared' stuff used by the GUI
>> (e.g. metaengine, game, savestate, etc).
>
> Yeah. I would love to get all this cleaned up, and with my email I hoped to trigger some brain storming. Alas, as usual, the storm turned out to be a mild breeze at most.

I agree on several points that have already been made and in
particular that the only sub-directories in engines/ should be for
engines.

I am not against having some files in the engines directory, but imho
it should be limited. Having the engine and meta engine theremakes
sense, but I am not sure for the main menu dialogs code for example.
And adding new files doesn't sound like a very good idea.

Having new sub-directories in common (e.g. for containers) and/or a
new top level directory (e.g. "formats") both sounds like they are
good ideas, although having "formats"as a sub-directory of common also
sounds fine to me.

> So, I'll just forget about this.

Please don't ;)

Thierry