[Scummvm-devel] MDT_PREFER_MT32 and MDT_PREFER_GM

Filippos Karapetis bluegr at gmail.com
Tue Mar 1 11:29:10 CET 2011


Further update... wjp and fuzzie found the cause for this one, and it has
been fixed
in re99dcac. It was caused from missing default values for MT-32 and GM.

Regards
Filippos

On Tue, Mar 1, 2011 at 11:38 AM, Filippos Karapetis <bluegr at gmail.com>wrote:

> Slight update on this... after the discussion in September 2010, there was
> a
> commit for this:
>
> https://github.com/scummvm/scummvm/commit/0db700a3dced67c607c9e9719ea22347612ead40
>
>
> <https://github.com/scummvm/scummvm/commit/0db700a3dced67c607c9e9719ea22347612ead40>I
> deleted my settings file, which left everything at default in the Audio tab,
> "Don't use
> General MIDI music" in the MIDI tab and "Don't use Roland MT-32 music" in
> the
> MT-32 tab. Still, with these settings, the following piece of code returns
> MT-32
> for musicType:
>
> uint32 deviceFlags = MDT_PCSPK | MDT_PCJR | MDT_ADLIB | MDT_MIDI |
> MDT_PREFER_MT32;
> uint32 dev = MidiDriver::detectDevice(deviceFlags);
> MusicType _musicType = MidiDriver::getMusicType(dev);
>
> That shouldn't happen... with the aforementioned default settings in the
> GUI, it
> should return MT_ADLIB...
>
> Regards
> Filippos
>
> On Tue, Mar 1, 2011 at 10:50 AM, Filippos Karapetis <bluegr at gmail.com>wrote:
>
>> Hello
>>
>> I checked a bit the usage of MDT_PREFER_MT32 and MDT_PREFER_GM,
>> and updated the comments concerning them.
>>
>> Currently, MDT_PREFER_MT32 is a bit problematic. If the default audio
>> settings are used, and an engine defines MDT_PREFER_MT32, then on
>> desktop systems the Munt emulator is selected as a "best/preferred" device
>> (unless a real MT-32 device is present).
>>
>> This isn't ideal IMHO, since it basically forces people to use Munt. Users
>> who haven't changed their music settings will probably not even know what
>> Munt is, and will be confused by the cryptic "you need XXX roms images" in
>> order to get it working.
>>
>> The situation is a bit similar with MDT_PREFER_GM, but I consider this one
>> a "feature", as it'll pick up a GM MIDI device with the default music
>> settings,
>> and most modern systems have GM MIDI capabilities. Thus, this one will
>> actually pick up a "good" setting in the games that want it, without
>> forcing
>> the user to use Munt.
>>
>> Therefore, I'm a bit baffled by the actual usage of MDT_PREFER_MT32... why
>> is
>> this needed at all, other than to force people to use Munt with the
>> default
>> audio settings? If a game engine requests MIDI output with MT-32 by
>> default, and
>> the default settings can't handle that, wouldn't it be a better idea to
>> switch to the
>> Adlib emulator by default, instead of Munt? IMHO, Munt shouldn't fire up
>> with the
>> default settings, cause this is mostly confusing for people who don't know
>> what
>> it is and get a dialog to provide ROM files which they probably don't
>> have...
>>
>> Regards
>> Filippos
>>
>> --
>> "Experience is the name every one gives to their mistakes" - Oscar Wilde
>>
>
>
>
> --
> "Experience is the name every one gives to their mistakes" - Oscar Wilde
>



-- 
"Experience is the name every one gives to their mistakes" - Oscar Wilde
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20110301/249f9c01/attachment.html>


More information about the Scummvm-devel mailing list