[Scummvm-devel] Introducing a GSOC student

[Jussi Pitkanen]

On Fri, May 06, 2011 at 10:42:41AM +0200, Max Horn wrote:
> Hi Jussi,
> 
> a very belayed "welcome aboard". Looking forward to your work.
> 
> Will you also look into fixing some existing AGI bugs? E.g. this one is an old one, yet fixing it shouldn't be a major problem: <https://sourceforge.net/tracker/?func=detail&atid=418820&aid=2581253&group_id=37116>

I'm willing to fix any bugs that are related to those parts of the code
that I am going to work on. Will familiarize myself with the bug
descriptions from the tracker. Thanks for pointing this out.

About this particular one: Comparing to the current code, it seems to me
that the clock is updated correctly. Take a look at AgiEngine::mainCycle()
(cycle.cpp): it first calls pollTimer() which waits for 50ms (1/20 second),
and then in updateTimer() increments _clockCount, which will in turn be
used to increment the clock after it exceeds TICK_SECONDS (20). Based on
this, I don't immediately see what is the problem here. It also makes it
look like that it is natural that it works in KQ3. Instead, it seems
like the clock is handled by some different mechanism in GR. But then, I
haven't tried either of these games. I am a little hesitant to add this
to the comments there just yet since I don't know this code very well and
might still be overlooking something. Maybe you or sev could take another
look into this?

- Jussi