[Scummvm-devel] png

[D G Turner]

Johannes / Bertrand,
   Yes, you are correct. It was mainly portability concerns and the
   KISS principle applied to trying to minimise external dependencies.

   After listening to the points raised, examining our current
   PNG decoder code and looking at the libpng code and website:
   http://www.libpng.org/pub/png/libpng.html

   I have to retract my objections to using libpng.

   As Bertrand has indicated, and the website confirms, it is
   written in pure ANSI C (C89) with portability in mind, is OSI
   certified OSS, stable and well maintained, so linking to it should
   not be an issue.

   If it is, or if we really do need a fallback/custom decoder: Since
   this is GPL compatible OSS, we do have the option of including the
   libpng code or a derived decoder within the ScummVM codebase, but
   I don't think this will be necessary.
Thanks,
David Turner

On 07/25/12 00:46, Bertrand Augereau wrote:
> I understand his concern because building in-tree code is always much
> easier than linking to other libs, especially on exotic platforms :)
> 
> Bertrand
> 
> ________________________________ De : Johannes Schickel
> <lordhoto at gmail.com> À : Bertrand Augereau
> <bertrand_augereau at yahoo.fr> Cc : D G Turner
> <d.g.turner at ntlworld.com>; "scummvm-devel at lists.sourceforge.net"
> <scummvm-devel at lists.sourceforge.net> Envoyé le : Mercredi 25 juillet
> 2012 1h39 Objet : Re: [Scummvm-devel] png
> 
> On 07/25/2012 01:26 AM, Bertrand Augereau wrote:
>> Just a sidenote guys, libpng is not optimized, it is more of a
>> reference code with portability in mind. No SIMD nor per-platform
>> code there. It may not be important though :)
> 
> Portability sounds like what digitall was worried about, so this is
> probably a good thing? ;-)
> 
> // Johannes