[Scummvm-devel] Theora Player

[Федор]

 Look at  http://svn.xiph.org/trunk/ogg/include/ogg/os_types.h  : ogg_int32_t in known for me cases always int. 

Here compiler try set second parameter in vorbis_synthesis_pcmout() with float instead int. This cause compiler error:

/Symbian/Projects/SDL/scummvm/video/theora_decoder.cpp: In member function 'bool Video::TheoraDecoder::VorbisAudioTrack::decodeSamples()':
/Symbian/Projects/SDL/scummvm/video/theora_decoder.cpp:363: error: 'signed' or 'unsigned' invalid for 'pcm'
/Symbian/Projects/SDL/scummvm/video/theora_decoder.cpp:366: error: cannot convert 'float***' to 'ogg_int32_t***' for argument '2' to 'int vorbis_synthesis_pcmout(vorbis_dsp_state*, ogg_int32_t***)

Панядзелак, 16 снежня 2013, 17:10 UTC ад Willem Jan Palenstijn <wjp at usecode.org>:
>On Mon, Dec 16, 2013 at 03:28:31AM +0400, Федор wrote:
>>  Hi! Are you planned add support Tremor/Tremolo to builtin theora player?
>> I look at theora_decoder.h and theora_decoder.cpp. To make it compatible with
>> Tremor/Tremolo necessary make this steps :
>> 1) in theora_decoder.cpp in line 363 pointer **pcm declared as unsigned float
>> but in ivorbiscodec.h it has ogg_int32_t type
>
>
>> This type may be signed or not at various  OS. You can declare it as ogg_int32_t
>
>Really? That would be surprising, especially since there's also an ogg_uint32_t.
>Do you have a reference for this claim?
>
>-Willem Jan
>
>------------------------------------------------------------------------------
>Rapidly troubleshoot problems before they affect your business. Most IT 
>organizations don't have a clear picture of how application performance 
>affects their revenue. With AppDynamics, you get 100% visibility into your 
>Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
>http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
>_______________________________________________
>Scummvm-devel mailing list
>Scummvm-devel at lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/scummvm-devel


С уважением, Федор Стрижнёв.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20131216/708af60a/attachment.html>