[Scummvm-devel] compiler can't find config.h in pluto.cpp in Broken Sword 2.5

[Willem Jan Palenstijn]

On Mon, Nov 04, 2013 at 08:18:46PM +0000, Willem Jan Palenstijn wrote:
> On Mon, Nov 04, 2013 at 08:10:33PM +0000, Willem Jan Palenstijn wrote:
> > On Mon, Nov 04, 2013 at 06:55:19PM +0100, Johannes Schickel wrote:
> > > On 11/04/2013 02:22 PM, Willem Jan Palenstijn wrote:
> > > > config.h is generated by our configure script.
> > > >
> > > > It's an interesting question why pluto.cpp includes it directly without going
> > > > through common/scummsys.h or using the #ifdef HAVE_CONFIG_H guard, though. How
> > > > does this work when using create_project, which AFAICT doesn't generate a
> > > > config.h?
> > > 
> > > I think it simply doesn't work for MSVC etc. which doesn't have a 
> > > config.h ;-).
> > 
> > That's what I'm afraid of.
> > 
> > Strangely the very first thing the very next header includes is scummsys.h...
> 
> Aha, that config.h was added as a wrong compilation fix in 6dc3768faaa272a12e3c6e7ce0965905338132ad.
> 
> That commit should probably just be reverted.

I've reverted it, and buildbot reports no problems as expected. So config.h is
now gone from pluto.cpp.

-Willem Jan