[Scummvm-devel] coverity

[Paul Gilbert]

Just to throw in my 2 cents, it may be partly due to the games I've worked
on and/or my own personal style, but I always try to code all
initialization in the constructors, except in rare cases like the TsAGE
globals classes, where I need to be able reset the entire class contents
back to a predefined state without recreating it. As such, the types of
errors Coverity generate would be extremely relevant for me, since it would
indicate a variable that I hadn't initialized, and likely should have, and
would have a tendency to cause problems. Whilst I understand the argument
about it possibly being an advantage to see problems in Valgrind, I
personally wouldn't see that as a big enough reason not to have the classes
properly initialized.

But in any case, I concur with what was set earlier, in that I have no
problem handling such changes on a case by case basis.

Paul.

On Sat, Nov 9, 2013 at 5:19 PM, Johannes Schickel <lordhoto at gmail.com>wrote:

> Isn't the unstable behavior you talk about a clearly visible indicator
> for an actual regression from the refactoring whereas with the simple
> variable initialization it might be hidden (but not fixed) and thus make
> it harder to figure out the problem?
>
> // Johannes
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20131109/fdc541b8/attachment.html>