[Scummvm-devel] R: Re: ScummVM-PS2 Mysteries #2: createPixelFormat<555> vs <1555>

[sunmax at libero.it]

Hi Marcus,

I will do today ;-)

Thanks for the suggestion!
-max

>----Messaggio originale----
>Da: marcus at mc.pp.se
>Data: 26/01/2014 16.45
>A: "sunmax at libero.it"<sunmax at libero.it>
>Cc: <scummvm-devel at lists.sourceforge.net>
>Ogg: Re: [Scummvm-devel] ScummVM-PS2 Mysteries #2: createPixelFormat<
555> vs <1555>
>
>
>Hi Max,
>
>"sunmax at libero.it" <sunmax at libero.it> writes:
>
>> starting from 1.5.0 (I didn't have a chance to trace the specific commit 
yet) 
>> the Launcher GUI (when you use Classic theme) and also the GMM in the 
games, 
>> will have a blue-ish tint in the transparency on PS2.
>>
>> This appears related to createPixelFormat<1555> in getOverlayFormat.
>>
>> We can get the GUI Launcher to look good with Classic theme using 
>> createPixelFormat<555>  ("555" in place of "1555") but then the color ot 
the 
>> games will be broken...
>>
>> On the other hand, we can still getting this to work fine by creating the 
>> overlayFormat by hand (see _overlyFormat in Gs2dScreen.cpp:203) and specify 
it 
>> is as "555". Interestingly enough the "555" specified by hand, works where 
>> createPixelFormat<555> appears to be broken.
>
>
>Did you try this with current HEAD?
>
>There was a bug (introduced in 905f959, fixed in 51d7405 by me) which
>caused the classic UI to get incorrect background colours when the
>overlay has alpha.  On the Dreamcast, the error appeared as red
>instead of blue, but this would depend on the exact pixel format.
>
>
>  // Marcus
>
>
>