[Scummvm-devel] SCUMM Steam Releases

Filippos Karapetis bluegr at gmail.com
Sun Jun 22 15:22:55 CEST 2014


I've made a pull request for this here:
https://github.com/scummvm/scummvm/pull/470

The changes are based on Ben Castricum's work, but I've opted for a less
invasive patch - all the file handling is done at the file handle level,
which makes the changes more self-contained rather than scattered in
different parts of the engine.

The pull request doesn't handle CDDA.SOU yet - I too agree that this
shouldn't be handled outside of the SCUMM engine. If people feel that this
should be handled in the SCUMM engine (which is the best and cleanest way,
IMHO), then this part can be rewritten into a separate commit.

Regards
Filippos


On Thu, Jun 12, 2014 at 11:07 PM, Matthew Hoops <clone2727 at gmail.com> wrote:

> It's not a pull request, but I'll comment on it here anyway: Inserting
> CDDA.SOU-related outside of SCUMM is unacceptable.
>
> Matt
> On Jun 12, 2014 3:45 PM, "Ben Castricum" <scummvm at bencastricum.nl> wrote:
>
>> On 4-6-2014 16:42, Eugene Sandulenko wrote:
>> > Okay, in this case majority wins, please submit a pull request.
>>
>> In case anyone is going to develop a steam support patch based on that
>> old patch I once wrote for v1.4, I updated it to the current master
>> branch. I playtested it a bit and it still seems to work.
>>
>> https://github.com/BenCastricum/scummvm/tree/steam
>>
>> Cheers,
>> Ben
>>
>>
>> ------------------------------------------------------------------------------
>> HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
>> Find What Matters Most in Your Big Data with HPCC Systems
>> Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
>> Leverages Graph Analysis for Fast Processing & Easy Data Exploration
>> http://p.sf.net/sfu/hpccsystems
>> _______________________________________________
>> Scummvm-devel mailing list
>> Scummvm-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/scummvm-devel
>>
>
>
> ------------------------------------------------------------------------------
> HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
> Find What Matters Most in Your Big Data with HPCC Systems
> Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
> Leverages Graph Analysis for Fast Processing & Easy Data Exploration
> http://p.sf.net/sfu/hpccsystems
> _______________________________________________
> Scummvm-devel mailing list
> Scummvm-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/scummvm-devel
>
>


-- 
"Experience is the name every one gives to their mistakes" - Oscar Wilde
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20140622/f51a4556/attachment.html>


More information about the Scummvm-devel mailing list