[Scummvm-devel] New server donated to ScummVM

[D G Turner]

On 02/03/15 18:23, Willem Jan Palenstijn wrote:
> On Mon, Mar 02, 2015 at 06:21:09PM +0000, D G Turner wrote:
>> All,
>>   Just as an FYI for the list.
>>
>>   The Buildbot configuration already has provision for a Pull Request
>>   builder since April 2014:
>>
>> https://github.com/scummvm/scummvm-sites/commit/85b26649ddcda1f4a7b572cb4f2b8212840b79d3
>>
>>   However, since the VM has been limited by Disk Space and CPU, this
>>   was limited to a single "other" group and is normally disabled to
>>   prevent Disk Space issues.
>>
>>   If the buildbot is migrated to the newer server, then I should be
>>   easily able to enable this and expand to cover all PRs.
> 
> 
> Interesting. In that setup, how would we select which revisions of which pull
> requests are ready to be built?

Since a Pull Request is just a branch in the Git repository, then the
new builder group is just another copy of the master / stable builder
groups with a different branch URL. You change the current one as per:
https://github.com/scummvm/scummvm-sites/commit/5bc2f13dee33de7ece80a10f3f537a7b21a0cd5f

I'd be a little wary about making it automatic that new PRs are picked
up and built on the server due to the following:

Anyone can create a new Github account, fork the repository and insert a
malicious piece of code in say the ScummVM configure bash script to root
the server.. They then issue a PR, this is automatically picked
up by the buildbot and during the build, the malicious code is executed :/

I would suggest it would be best that new PRs are added manually after
a human vetting them.

I would however intend to expand the Buildbot configuration Python code
to get all the PR branches from the ScummVM main repository as per:
http://nedbatchelder.com/blog/201407/fetching_github_pull_requests.html

This would remove the need to clone a second repository for each branch
which is currently the case as per 5bc2f13dee33de7ece80a10f3f537a7b21a0cd5f.

I would also intend to make adding a new builder group, a single line
function call, rather than alot of cut and paste...

A bit of Python work to do these, but not very much once Disk Space and
CPU are not constraining...

> -Willem Jan
>