No subject


Fri Aug 26 13:14:27 CEST 2016


applications but is a feature that is nice to have.

> 
> 	* scummvm doesn't exit if can't subscribe to another Alsa seq client, insted
> 	  an error message is shown and the user has the chance to connect manually 
> 	  (e.g. with aconnect or within his favorite sequencer application)

You misunderstand the code, error() is fatal (the return statement
should not have been there).  I don't really see how this would work anyway.
Besides this should be reported on launching ScummVM so its not really a
great hassle for the user to have to start again.

I applied the patch with some syntax nits/hand merging and shortened the
error string.  In addition to acconnect/SCUMMVM_PORT alsa_port can also
be specified in the config file however we don't really need to
enumerate these, especially considering the user probably specified a
port already at this point.  The error string in your patch was
already several lines long which was overlapping parts of the readme.

regards
Jonathan




More information about the Scummvm-devel mailing list