[Scummvm-devel] ATTN Porters: Tests for the new C++ standards

[Thierry Crozat]

Hi all,

I just pushed an update to the test with the following changes.

1. The configure flag was renamed for consistency. Now you need to use:

./configure --enable-c++11 --enable-test-c++11

2. One of the test  for initializer list was incomplete and disabled by default (as it did not compile even with c++11 compliant compilers). It has now been fixed and is enabled by default.

There are two variants of the test. By default it tries to use the std::initializer_list from the c++ standard library. If you have a c++11 compliant compiler, but are targeting a c++ standard library that does not have std::initializer_list, the test may fail. In this case, before disabling the test altogether, you can try to enable the std::initializer_list replacement with:

#define USE_INITIALIZIER_LIST_REPLACEMENT

Thierry


> On 27 May 2020, at 18:40, Eugene Sandulenko <sev at scummvm.org> wrote:
> 
> Oh, right, sorry, I kind of forgot.
> 
>   ./configure --enable-c++11 --enable-test-cpp11
> 
> Eugene
> 
> On Wed, 27 May 2020 at 19:12, Luc Schrijvers <begasus at gmail.com <mailto:begasus at gmail.com>> wrote:
> Hi team,
> 
> On a quick checkout I get the following error (link will stay up for about a month: https://paste.ubuntu.com/p/6Fyzyqx3TN/ <https://paste.ubuntu.com/p/6Fyzyqx3TN/>
> 
> Greetings,
> 
> Luc aka Begasus
> 
> Op wo 27 mei 2020 om 13:05 schreef Eugene Sandulenko <sev at scummvm.org <mailto:sev at scummvm.org>>:
> Hi Team,
> 
> Time flies, compilers improve, and one of the most frequent requests is to switch ScummVM to a newer standard of C++.
> 
> Of course, our primary project goal is portability, thus, we need to assess the readiness carefully. I will include this in our next release process as a step to check, but still, it would be great to get information as soon as possible.
> 
> Thus, all porters, could you please get the latest master, and run configure with the following flag:
> 
>    ./configure --enable-test-cpp11
> 
> This will add base/test_new_standards.cpp file to the compilation (or add it manually if you use a different build system. The file is a no-op, but checks compilation of the new desired features of c++11 standard. If you have some compilation error, there is a way to disable specific tests, and see which things could and which couldn't be supported. Then report this to me, or directly put the results on the Wiki: https://wiki.scummvm.org/index.php?title=Compiling_ScummVM/C%2B%2B11_Readiness <https://wiki.scummvm.org/index.php?title=Compiling_ScummVM/C%2B%2B11_Readiness>
> 
> The details of the code and description could be found in this PR by ZvikaZ:
> 
>   https://github.com/scummvm/scummvm/pull/2259 <https://github.com/scummvm/scummvm/pull/2259>
>    
> Also, if you have general ideas about the effort or additional tests, please share them.
> 
> 
> Eugene
> _______________________________________________
> Scummvm-devel mailing list
> Scummvm-devel at lists.scummvm.org <mailto:Scummvm-devel at lists.scummvm.org>
> https://lists.scummvm.org/listinfo/scummvm-devel <https://lists.scummvm.org/listinfo/scummvm-devel>
> _______________________________________________
> Scummvm-devel mailing list
> Scummvm-devel at lists.scummvm.org
> https://lists.scummvm.org/listinfo/scummvm-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20200529/5d1ed1e7/attachment.htm>