[scummvm-devel] RFC: What should happen when adding \0 to a String?

Torbjörn Andersson eriktorbjorn at telia.com
Wed Jul 7 10:42:03 UTC 2021


On 30/06/2021 10.10, Walter van Niftrik wrote:
> I agree with Filippos and think we should model this after std::string.
> 
> Walter
> 

So are there any objections to making that change now, so that we can 
deal with whatever the fallout now rather than just before the next 
release (whenever that is)? The warning would be kept for now, but 
probably reworded.

As I recall it, we've already fixed regressions this behavior would 
cause in Mohawk and Myst3, as well as a few probably harmless cases 
elsewhere. And making the change should fix the ADL engine, which is 
currently completely broken for at least Time Zone and The Dark Crystal.

Torbjörn Andersson


More information about the scummvm-devel mailing list