[Scummvm-cvs-logs] CVS: scummvm gfx.cpp,1.88,1.89

Lionel Ulmer bbrox at users.sourceforge.net
Tue May 14 14:56:02 CEST 2002


Update of /cvsroot/scummvm/scummvm
In directory usw-pr-cvs1:/tmp/cvs-serv15560

Modified Files:
	gfx.cpp 
Log Message:
Fix the Valgrind warning about the save game menu in Zak. 

I think that it's better to compute the height with the modified
parameters and not with the original ones. Endy, otherse, please
comment :-)

Anyway, there seems to be some bugs remaining :

 1) the save game menu is really weird looking (ie instead of having
    the game name displayed in the top left, there is 'How may I serve
    you ?' instead (maybe normal after all :-) and there seems to be
    some black missing).

 2) in the same code I move, there is this :

	if(height > 200)
		height = 200;

    Why limit at 200 for a game that supports 240 :-) ?



Index: gfx.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/gfx.cpp,v
retrieving revision 1.88
retrieving revision 1.89
diff -u -d -r1.88 -r1.89
--- gfx.cpp	12 May 2002 17:51:40 -0000	1.88
+++ gfx.cpp	14 May 2002 21:55:17 -0000	1.89
@@ -210,11 +210,6 @@
 	int scrollY;
 	int height;
 
-	height = b - t;
-
-	if(height > 200)
-		height = 200;
-
 	if (b <= t)
 		return;
 
@@ -223,6 +218,10 @@
 
 	if (b > vs->height)
 		b = vs->height;
+
+	height = b - t;
+	if(height > 200)
+		height = 200;
 
 	scrollY = _vm->camera._cur.y - 100;
 	if(scrollY == -100)





More information about the Scummvm-git-logs mailing list