[Scummvm-cvs-logs] CVS: scummvm/simon debug.cpp,1.7,1.8

Max Horn fingolfin at users.sourceforge.net
Wed Nov 20 05:20:03 CET 2002


Update of /cvsroot/scummvm/scummvm/simon
In directory sc8-pr-cvs1:/tmp/cvs-serv5772

Modified Files:
	debug.cpp 
Log Message:
fixed compilation for now <shudder>

Index: debug.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/simon/debug.cpp,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -d -r1.7 -r1.8
--- debug.cpp	20 Nov 2002 13:08:01 -0000	1.7
+++ debug.cpp	20 Nov 2002 13:19:50 -0000	1.8
@@ -403,6 +403,10 @@
 }
 
 void SimonState::dump_vga_bitmaps(byte *vga, byte *vga1, int res) {
+#if 0
+	// FIXME - this whole function doesn't compile on OS X and contains obvious bugs.
+	// E.g. offs is read but never set, same for width.
+
 	int i;
 	uint32 offs;
 	byte *p2;
@@ -417,13 +421,17 @@
 		pal_load(pal, vga1, 5, 3);
 	}
 
-	
+#if 0	
 	{
 		char buf[255], buf2[255];
 		sprintf(buf, "bmp_%d", res);
-		mkdir(buf2);
+		mkdir(buf2);	// FIXME - WTF is this ???
+			// First off, mkdir() is not very portable. 
+			// Secondly, the Unix version of mkdir() has two arguments.
+			// Third, the buf2 is *never* set to anything.
+			// Fourth, why not use a sizeof 256 instead of 255?
 	}
-
+#endif
 
 	int width, height, flags;
 	
@@ -453,6 +461,7 @@
 			dump_bitmap(buf, vga + offs, width, height, flags, pal, 0);
 		}
 	}
+#endif
 }
 
 void SimonState::dump_vga_script_always(byte *ptr, uint res, uint sprite_id)





More information about the Scummvm-git-logs mailing list