[Scummvm-cvs-logs] CVS: scummvm/scumm saveload.cpp,1.16,1.17 string.cpp,1.34,1.35

Max Horn fingolfin at users.sourceforge.net
Thu Oct 24 23:28:02 CEST 2002


Update of /cvsroot/scummvm/scummvm/scumm
In directory usw-pr-cvs1:/tmp/cvs-serv28805/scumm

Modified Files:
	saveload.cpp string.cpp 
Log Message:
TODO comment

Index: saveload.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/saveload.cpp,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -d -r1.16 -r1.17
--- saveload.cpp	23 Oct 2002 00:22:55 -0000	1.16
+++ saveload.cpp	24 Oct 2002 21:39:44 -0000	1.17
@@ -585,6 +585,10 @@
 	};
 
 	const SaveLoadEntry stringTabEntries[] = {
+		// TODO - It makes no sense to have all these t_* fields in StringTab
+		// Rather let's dump them all when the save game format changes, and 
+		// keep two StringTab objects: one normal, and a "t_" one.
+		// Then copying them can be done in one line etc.
 		MKLINE(StringTab, xpos, sleInt16),
 		MKLINE(StringTab, t_xpos, sleInt16),
 		MKLINE(StringTab, ypos, sleInt16),

Index: string.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/string.cpp,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -d -r1.34 -r1.35
--- string.cpp	23 Oct 2002 14:02:46 -0000	1.34
+++ string.cpp	24 Oct 2002 21:39:45 -0000	1.35
@@ -170,6 +170,8 @@
 	if (_string[3].color == 0)
 		_string[3].color = 4;
 
+	// TODO - it appears the this function should display the given message graphically
+	// to the user in a "dialog" looking like the pause dialog, i.e. a single line.
 	warning("unkMessage2(\"%s\")", buf);
 	_messagePtr = tmp;
 }
@@ -717,7 +719,7 @@
 		return NULL;
 	}
 
-while ((ptr[num++] = chr = *msg++) != 0) {
+	while ((ptr[num++] = chr = *msg++) != 0) {
 		if (num >= 500)
 			error("Message stack overflow");
 





More information about the Scummvm-git-logs mailing list