[Scummvm-cvs-logs] CVS: scummvm/scumm script_v5.cpp,1.140,1.141

Max Horn fingolfin at users.sourceforge.net
Sun Aug 3 11:27:06 CEST 2003


Update of /cvsroot/scummvm/scummvm/scumm
In directory sc8-pr-cvs1:/tmp/cvs-serv25155

Modified Files:
	script_v5.cpp 
Log Message:
removed obsolete warning

Index: script_v5.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/script_v5.cpp,v
retrieving revision 1.140
retrieving revision 1.141
diff -u -d -r1.140 -r1.141
--- script_v5.cpp	3 Aug 2003 18:23:54 -0000	1.140
+++ script_v5.cpp	3 Aug 2003 18:26:46 -0000	1.141
@@ -667,20 +667,11 @@
 		break;
 	case 14:											/* unk */
 		if (_features & GF_OLD_BUNDLE || _gameId == GID_INDY3_256 || _gameId == GID_INDY3_TOWNS) {
-			// FIXME: What is this supposed to do? From comparing
-			// Indy3's script 118 to the Passport Demo's script 58
-			// my guess is that it's some sort of "init charset",
-			// but why does it need two parameters?
 			int a = getVarOrDirectByte(0x80);
 			int b = getVarOrDirectByte(0x40);
-			warning("o5_cursorCommand: unknown subopcode 14 (init charset?): %d, %d", a, b);
-			// Maybe the following is what to do (or maybe b instead of a); since I have only
-			// seen a = b = 1, this is not clear; still even if this is right, what's b?
-			// loadCharset(a);
-			// Assuming this is correct, we might not actually need it, as our
-			// initCharset automatically calls loadCharset for GF_SMALL_HEADER, if needed.
-			// Loom ega at least does need this and v2 has its own cursor command
-			// so making this for OLD_BUNDLE.
+			// This is some kind of "init charset" opcode. However, we don't have to do anything
+			// in here, as our initCharset automatically calls loadCharset for GF_SMALL_HEADER,
+			// games if needed.
 		} else {
 			getWordVararg(table);
 			for (i = 0; i < 16; i++)





More information about the Scummvm-git-logs mailing list